Add egraph.function_values(fn) to export all function values like print-function
#340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@actions-user changelog |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new method egraph.function_values(fn) to export all function values, providing a Python equivalent to the egglog print-function command.
- Adds
function_values()method to EGraph class that returns a dictionary mapping function calls to their values - Refactors
_callable_to_egg()to return both CallableRef and string for better internal API - Updates documentation and changelog to reflect the new functionality
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| python/egglog/egraph.py | Implements function_values() method and refactors _callable_to_egg() to return tuple |
| python/tests/test_high_level.py | Adds test for the new function_values() functionality |
| docs/reference/egglog-translation.md | Documents the new method as equivalent to print-function command |
| docs/changelog.md | Records the new feature in the changelog |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
CodSpeed Instrumentation Performance ReportMerging #340 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.